Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests never starts with wait-on #42

Closed
alexbjorlig opened this issue Nov 25, 2019 · 2 comments · Fixed by #43
Closed

Cypress tests never starts with wait-on #42

alexbjorlig opened this issue Nov 25, 2019 · 2 comments · Fixed by #43
Labels

Comments

@alexbjorlig
Copy link

I am trying to setup this action with a simple Angular + Nodejs server, but I am stuck. No tests actually starts. This might be a possible duplicate of #41

- name: Run e2e tests
  uses: cypress-io/github-action@v1
  with:
    # we have already installed all dependencies above
    install: false
    start: npm run -s start:test & npm run -s start:test --prefix aveiro-server
    wait-on: http-get://localhost:4200/
    config-file: cypress.json
    wait-on-timeout: 180

But the wait-on property does not seem to work when executing on Github. When I look at the logs, I can confirm that both the server and angular is serving - but nothing happens. Then after 180 seconds the job times out.

The weird thing is that if i on localhost do npm run -s start:test & npm run -s start:test --prefix aveiro-server and in another window wait-on http-get://localhost:4200/ && echo Ready! everything works as expected - after the server and angular is up and running, I see "Ready!" in the other console window.

Any help is very welcome.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexbjorlig
Copy link
Author

Thanks for the fix - amazing response time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant