Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harmonize npm name usage in logs #888

Merged
merged 1 commit into from
May 5, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR modifies the action source file index.js for consistency with

  • the npm documentation About npm which uses lower case npm and with
  • the Cypress documentation Module API which does not include NPM in its name

Changes

  • Text and comments now refer to npm consistently in lower case.
  • NPM is removed from the reference to the Cypress Module API

@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Apr 27, 2023

It is the last PR in a series concerned with adding pnpm and Yarn to the list of supported package manager lockfiles supported for installation. This small change triggered a whole lot of other changes making sure that npm was consistently referred to.

When this PR is merged it will trigger an npm release and that will also update the README on https://www.npmjs.com/package/@cypress/github-action, so before that happens all the other documentation changes should have completed.

For some strange reason the README on https://github.com/marketplace/actions/cypress-io is updated even without a release, except that the display of the value of the released version number is only updated with a release to the GitHub Marketplace!

@MikeMcC399 MikeMcC399 force-pushed the fix/npm-naming-action branch 5 times, most recently from d0472f6 to 244872f Compare May 3, 2023 20:01
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 3, 2023 20:08
@MikeMcC399
Copy link
Collaborator Author

Please review. Thanks.

@mschile mschile self-assigned this May 5, 2023
@MikeMcC399

This comment was marked as resolved.

@MikeMcC399
Copy link
Collaborator Author

Rebased and ready again 🙂

@MikeMcC399 MikeMcC399 marked this pull request as draft May 5, 2023 15:24
@mschile mschile requested a review from AtofStryker May 5, 2023 15:24
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 5, 2023 15:35
@mschile mschile merged commit dfda936 into cypress-io:master May 5, 2023
114 checks passed
@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the fix/npm-naming-action branch May 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants