You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! First of all, thank for this module. It is really helpful =)
So, I have seen that here it was added errorThreshold in global options.
But as far as I tested and debugged the code, it is only took in consideration if we pass an object as second argument.
I will try to explain better with code:
compareSnapshotCommand({
capture: "fullPage",
errorThreshold: 0.04,
});
cy.compareSnapshot("home", 0.03); // use 0.03 as errorThreshold -> ok
cy.compareSnapshot("home"); // won't use global options errorThreshold. Instead will use 0 -> is this intentional?
cy.compareSnapshot("home", {}); // will use the global options errorThreshold
If this is not intentional, I think there is an easy way to solve that.
Let me know if I can open a PR related to this possible issue.
And, again, thanks for the module =)
The text was updated successfully, but these errors were encountered:
Hi! First of all, thank for this module. It is really helpful =)
So, I have seen that here it was added
errorThreshold
in global options.But as far as I tested and debugged the code, it is only took in consideration if we pass an object as second argument.
I will try to explain better with code:
If this is not intentional, I think there is an easy way to solve that.
Let me know if I can open a PR related to this possible issue.
And, again, thanks for the module =)
The text was updated successfully, but these errors were encountered: