FloatFilter to support empty_is_nil option #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, firstly thanks for the work on Mutations. It is really helpful library for us in both small and medium sized projects for business logic.
I just noticed that FloatFilter did not have empty_is_nil option like in IntegerFilter.
This PR is adding that functionality.
It's useful just like in IntegerFilter, float values can also be "" and it would be nice to handle it in the mutations rather than filtering and making them nil manually, as right now, they will not pass validations at Mutations and return an error that
Field is blank.Would appreciate if this is merged.