This repository has been archived by the owner on Jul 9, 2019. It is now read-only.
Fix for err in rejects from GoogleLogin promises being empty object #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when a Promise rejects from a GoogleLogin method, the err returned in the reject is just an empty object. For example:
login.login(username, password).then(token => { //do stuff with token }, err => { console.log(err) //err prints as '{}' });
Changing the Promises to reject with the statusCode and statusMessage of the response at least gives a (reasonably) meaningful error.
I'm not sure if the same thing happens with PTCLogin methods or not. I have not tried them.