Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-tests.yml #270

Merged
merged 9 commits into from
Apr 17, 2022
Merged

Update run-tests.yml #270

merged 9 commits into from
Apr 17, 2022

Conversation

kudashevs
Copy link
Contributor

@kudashevs kudashevs commented Mar 18, 2022

Hello,

I would like to propose some improvements to the CI/CD workflow. This PR:

  • adds support of PHP 8.1 (with all necessary exclusions)
  • adds caching of composer dependencies (it is really optional, and if it doesn't seem reasonable I'll remove it)
  • removes non-used PHP extensions (it speeds up a little bit)
  • removes installation of the specific minimum versions of fzaninotto/faker and laravel/legacy-factories (it seems to work perfectly without the specific versions)
  • adds installation of the specific minimum versions required by PHP 8.1 and Laravel 8.0 with prefer-lowest (I did it just in case. An explanation is below)

PS I'd prefer to totally exclude PHP 8.1 and Laralve 8.0 with prefer-lowest from processing (because it requires too many different minimum versions). However, the decision is up to you.

@cyrildewit cyrildewit self-requested a review April 17, 2022 10:57
@cyrildewit cyrildewit merged commit db1d229 into cyrildewit:master Apr 17, 2022
@cyrildewit
Copy link
Owner

Thanks @kudashevs. I appreciate your work on this.

PS I'd prefer to totally exclude PHP 8.1 and Laravel 8.0 with prefer-lowest from processing (because it requires too many different minimum versions). However, the decision is up to you.

I think it's always good to test it for multiple Laravel versions. Even if it requires some extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants