Allow epub: attributes
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, `epub:` attributes are stripped. There are currently only two of these attributes defined by [the standard][1]: - `epub:type` - `epub:prefix` The `epub:type` prefix in particular is very useful for adding semantic information about content for things like nicer footnote behaviour. This change adds the above attributes to the attribute whitelist. For ease of development, this change also adds `coffeescript` to the list of development dependencies, and adds an `npm` script so that the project can be compiled: `npm run compile`. [1]: http://www.idpf.org/epub/31/spec/epub-contentdocs.html
alecgibson
force-pushed
the
epub-attrs
branch
from
5200de9
to
0b7f222
Compare
pedrosanta
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Good PR @alecgibson. 👍
Thank you for the neat npm script and dev dependency.
Sorry for this 'nuisance', of having to whitelist these attributes. As we've discussed on #49, we plan to scrap the processing of the chapters HTML contents altogether – which would avoid the issue this PR addresses –, I feel these contents should be of the sole responsibility of the lib user. Doing that processing hinders the flexibility of the lib and adds up unnecessary maintenance.
|
Fixes #47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
epub:attributes are stripped. There are currently onlytwo of these attributes defined by the standard:
epub:typeepub:prefixThe
epub:typeprefix in particular is very useful for adding semanticinformation about content for things like nicer footnote behaviour. This
change adds the above attributes to the attribute whitelist.
For ease of development, this change also adds
coffeescriptto thelist of development dependencies, and adds an
npmscript so thatthe project can be compiled:
npm run compile.