Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined config error with responsive-loader set as default #73

Merged

Conversation

christinecha
Copy link
Contributor

Currently, if you use defaultImageLoader: 'responsive-loader' in your config, your next build will error out because there is no return value at the end of applyResponsiveLoader, so your whole webpack/next config becomes undefined.

This should fix that!

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #73 into master will decrease coverage by 0.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   92.89%   92.35%   -0.55%     
==========================================
  Files          13       13              
  Lines         169      170       +1     
  Branches       40       40              
==========================================
  Hits          157      157              
- Misses          9       10       +1     
  Partials        3        3
Impacted Files Coverage Δ
lib/loaders/responsive-loader.js 72.72% <0%> (-7.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e9209...b4ee3e6. Read the comment docs.

@cyrilwanner
Copy link
Owner

Oops, I totally missed this. Thank you @christinecha very much for this bug fix! I'll publish it to NPM in a few minutes.

@cyrilwanner cyrilwanner changed the title Fix undefined config error when { defaultImageLoader: 'responsive-loader' } Fix undefined config error with responsive-loader set as default Apr 22, 2019
@cyrilwanner cyrilwanner merged commit 7b64bf9 into cyrilwanner:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants