Flags: check for corrrect untagged flags responses from STORE/FETCH #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brong
approved these changes
Oct 4, 2021
| # XXX when setting them as admin, suggesting they were already set, | ||
| # XXX and there's no explicit test that they were missing before being | ||
| # XXX set... | ||
|
|
There was a problem hiding this comment.
I wonder if this is due to sharedseen vs not sharedseen?
Our goal eventually is to have admin act as "owner" anyway.
| $msg{A}->set_attribute(flags => []); | ||
| $self->check_messages(\%msg); | ||
| } | ||
|
|
||
| xlog $self, "Cannot set one more wafer-thin user flag"; | ||
| my $flag = '$Farnarkle'; | ||
| $self->assert_null($allflags{$flag}); | ||
| my $r = $talk->store('1', '+flags', "($flag)"); |
There was a problem hiding this comment.
Yeah, good idea - $r is a bad name.
|
I think I also want these to check modseq before/after setting \Seen to make sure it's only bumped once, because the PR that "fixes" the issue may double bump it, and that wouldn't be good. |
elliefm
force-pushed
the
v32/3240-sharedseen-on-shared-mailbox
branch
from
bb4e647
to
69bb304
Compare
|
Moved to cyrusimap/cyrus-imapd#3829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here: one is a new regression test for cyrusimap/cyrus-imapd#3240 / cyrusimap/cyrus-imapd#3577, the other adds similar hardening to the tests that already existed.
I have a bunch of XXX comments in here on some weirdnesses that turned up that weren't directly relevant to the rabbit I was chasing. If you have thoughts on those I'd love to hear them, but otherwise I'll probably kick them down the road for now so I can get back to other things.