Skip to content

Commit

Permalink
auth.h: installed headers can't #include "lib/..."
Browse files Browse the repository at this point in the history
When our headers are installed, they're no longer buried under a
"lib/" subdirectory, which means installed headers using this spelling
can't find their dependencies, and that means third party code that
wants to link against libcyrus et al cannot be compiled.

Installed headers must spell it `#include "foo.h"`, not `#include "lib/foo.h"`

md5.h is not  installed, so the spelling it uses should not make a difference.
xsha1.h is not installed, but ought to be.  I've fixed the spelling in both
of these for consistency
  • Loading branch information
elliefm committed Jan 23, 2024
1 parent 5887e70 commit b1cf672
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/auth.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#ifndef INCLUDED_AUTH_H
#define INCLUDED_AUTH_H

#include "lib/strarray.h"
#include "strarray.h"

struct auth_state;

Expand Down
2 changes: 1 addition & 1 deletion lib/md5.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include <config.h>
#endif

#include "lib/assert.h"
#include "assert.h"

/*
* This is gnarly, sorry :( We might have been configured to build
Expand Down
2 changes: 1 addition & 1 deletion lib/xsha1.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

#include <config.h>

#include "lib/assert.h"
#include "assert.h"

#ifdef HAVE_SSL

Expand Down

0 comments on commit b1cf672

Please sign in to comment.