imported messages with junk Date headers messes up sorting for getMessageList

[wolfsage]

If you call importMessages and pass in messages with junk Date header fields, when you retrieve those messages (and others) back from getMessageList with sort = 'date desc', the emails with junk headers show up first with a date of the UNIX epoch. If internaldate is going to be used for the sorting, perhaps that should come back for the Date field as well?

A test showing the issue can be found here: wolfsage/JMAP-TestSuite@a1d6247

[rsto]

Why would we even want to allow to import messages with junk Date header fields? Shouldn't we reject the message? @brong, thoughts?

[brong]

Rejecting messages is generally pretty fraught. Junk date headers exist in the wild, for whatever reason, and the rest of the message still contains useful content. As for where they sort though, I don't particularly care - leaving that undefined is perfectly alright by me. So assuming they appear at a particular spot in getMessageList is not reasonable. Bron.

…

On Wed, 4 Jan 2017, at 20:06, Robert Stepanek wrote: Why would we even want to allow to import messages with junk Date header fields? Shouldn't we reject the message? @brong[1], thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[2], or mute the thread[3].

-- Bron Gondwana brong@fastmail.fm Links: 1. https://github.com/brong 2. #1773 (comment) 3. https://github.com/notifications/unsubscribe-auth/AABE7VuWZQbzVPmFqTTbHqFSbwT7FIFwks5rO2EbgaJpZM4LaDiK

[rsto]

Fair enough. So everyone's is OK to close this as no-fix?

[wolfsage]

I think this may surprise new users constantly.

Imagine a UI that tries to show newest messages first.

These broken messages will always sort at the top, yet display a date of "1970".

That seems wrong to me.

[wolfsage]

@brong, did be77394 fix this?

[wolfsage]

Hrm, nope, still seeing issues in our tests

[wolfsage]

I believe this is fixed now that internalDate is used for such things. Closing, thanks!