Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User cleanup is not safe against Xapian indexing #1927

Closed
brong opened this issue Apr 19, 2017 · 1 comment
Closed

User cleanup is not safe against Xapian indexing #1927

brong opened this issue Apr 19, 2017 · 1 comment
Assignees
@elliefm
Labels
3.0 affects 3.0 3.1 affects 3.1 dev releases

Comments

@brong
Copy link
Member

brong commented Apr 19, 2017

If a squatter is indexing as a user gets deleted, the xapian directories get deleted out from underneath the squatter, leading to IOERROR messages in the logs.

The user cleanup code should take an exclusive lock on the xapianactive file while it deletes the indexes.
@elliefm elliefm added 3.0 affects 3.0 3.1 affects 3.1 dev releases labels Apr 19, 2017
elliefm added a commit to elliefm/cyrus-imapd that referenced this issue Apr 19, 2017
@elliefm
search_xapian: hold write lock while unlinking activefile
f129a32 
Fixes cyrusimap#1927
@elliefm
Copy link
Contributor

elliefm commented Apr 19, 2017

How's this look? Seems like it should be straightforward, but double checking cause I don't know the search code well.

master...elliefm:v31/1927-xapian-lock-deleteuser

@elliefm elliefm self-assigned this Apr 19, 2017
elliefm added a commit to elliefm/cyrus-imapd that referenced this issue Apr 20, 2017
@elliefm
search_xapian: hold write lock while unlinking activefile
fdf59f8 
Fixes cyrusimap#1927
elliefm added a commit that referenced this issue Apr 20, 2017
@elliefm
search_xapian: hold write lock while unlinking activefile
19eac9b 
Fixes #1927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliefm elliefm

Labels
3.0 affects 3.0 3.1 affects 3.1 dev releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brong @elliefm