Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptloader: canonification should work across multiple domains #2282

Closed
tpokorra opened this issue Mar 5, 2018 · 1 comment · Fixed by #2283
Closed

ptloader: canonification should work across multiple domains #2282

tpokorra opened this issue Mar 5, 2018 · 1 comment · Fixed by #2283

Comments

@tpokorra
Copy link
Contributor

tpokorra commented Mar 5, 2018

Currently the ptloader expects the user to connect with a full e-mail address. If the user connects just with the UID, ptloader does not know which domain the user belongs to.

The solution in the pull request attached with this bug is: if there is no @ character in the canon_id, then collect all domains available from LDAP, and query each domain for the user with that UID. base will be set to that domain where the user exists.
@tpokorra tpokorra mentioned this issue Mar 5, 2018
Merged
elliefm pushed a commit that referenced this issue Jun 13, 2018
@elliefm
ptclient: implement canonification across multiple domains.
ed1a17b 
allow users to just connect with their UID.
this patch adds functionality to search each existing domain for the user UID via LDAP.
fixes #2282
@elliefm
Copy link
Contributor

elliefm commented Jun 13, 2018

I've just cherry-picked this across to the 3.0 branch too, it's very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ptclient: implement canonification across multiple domains.
2 participants
@tpokorra @elliefm