Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailbox/set httpd endless loop #2377

Closed
zvasilev opened this issue May 28, 2018 · 4 comments
Closed

Mailbox/set httpd endless loop #2377

zvasilev opened this issue May 28, 2018 · 4 comments
Assignees
Labels
jmap affects the jmap implementation

Comments

@zvasilev
Copy link

If you call Mailbox/set create and set non existent reference "#" for the 'parentId' parameter, httpd enter in endless loop.

@rsto rsto self-assigned this May 28, 2018
@rsto rsto added the jmap affects the jmap implementation label May 28, 2018
@rsto
Copy link
Member

rsto commented May 28, 2018

Thanks for reporting this! It even looped for all requests where there's only missing creationIds in parentId, so that really needed a fix.

@rsto rsto closed this as completed in 5e1aa1a May 28, 2018
@rsto
Copy link
Member

rsto commented May 28, 2018

Tested in cyrusimap/cassandane@3190f45

@zvasilev
Copy link
Author

Hello Robert,

Thank for fix the issue!

I have a problem with creating subfolders. Seems "Mailbox/set" doesn't honor "parentId" argument.
For example, when I try to create "Inbox" subfolder and pass inbox mailbox id, the folder is created but as a sibling of the inbox.
When I look at the code, I just saw it tries only if starts with '#' char.
Still not sure Am I read RFC correctly or is Cyrus bug.

My JSON payload is
{"methodCalls":[["Mailbox/set",{"create":{"1":{"name":"folder_123","parentId":"c8f73a59-4b7c-4549-8c03-0e267583b4e2"}}},"#13"]],"using":["ietf:jmap","ietf:jmapmail"]}

@rsto
Copy link
Member

rsto commented May 29, 2018

@zvasilev Your JMAP request looks OK to me.

Could you please create a new issue including the Mailbox/set request and response, and the response of a subsequent Mailbox/get for the two mailboxes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jmap affects the jmap implementation
Projects
None yet
Development

No branches or pull requests

2 participants