New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t114 dont replicate compiled sieve bytecode #13
Merged
brong
merged 9 commits into
cyrusimap:master
from
elliefm:v30/t114-dont-replicate-compiled-sieve
Aug 22, 2016
Merged
t114 dont replicate compiled sieve bytecode #13
brong
merged 9 commits into
cyrusimap:master
from
elliefm:v30/t114-dont-replicate-compiled-sieve
Aug 22, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silently ignore attempts to upload compiled bytecode (in case master server is running older version that still does this). We now need to link programs against libcyrus_sieve if they use the sync_support sources.
elliefm
force-pushed
the
v30/t114-dont-replicate-compiled-sieve
branch
from
August 17, 2016 02:52
c101547
to
4b4ecc6
Compare
@brong I'm starting to get blocked on this -- I've got a bunch of other changes ready to go (and more in progress) that will be conflict hell if I push them first. |
This was referenced Dec 13, 2016
This was referenced May 28, 2018
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Mar 29, 2021
These were converted to &cyrusimap#13; in XML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(From an old phabricator task: https://git.cyrus.foundation/T114)
This stops replication of binary sieve bytecode files. Instead, bytecode files are compiled by the replica on upload of the plain text script, or on activation via sync protocol. Attempts to replicate bytecode files are silently ignored.
A new sync protocol error is introduced, IMAP_SYNC_BADSIEVE, which will result if a replicated sieve script fails to parse/compile. This makes it important to ensure your master and replica servers have the same sieve extensions enabled.
Also, lmtpd now recompiles sieve bytecode files (if missing or stale) on demand. So a temporary parse/compile failure during replication is somewhat self-healing if the sieve script needs to actually be invoked later.
If an old master (without this change) syncs to a new replica (with this change):
If a new master (with this change) syncs to an old replica (without this change):
If a new master (with this change) syncs to a new replica (with this change):
This is somewhat invasive, so making it a pull request rather than just pushing it up.