cassandane.ini: don't choke on repeated params #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be required for Cassandane to run properly, but hasn't been required for a while.
Fixes a bug where if a param in the [config] section was specified more than once, we'd produce junk imapd.conf files, and then all tests would error out due to master aborting.
elliefm
added
backport-to-3.6
elliefm
removed
backport-to-3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if a parameter in the
[config]section of cassandane.ini was specified more than once, Cassandane would produce junk imapd.conf files, and then all tests would error out due to master aborting.Now, if a parameter is specified multiple times, the last value read takes precedence, and a warning is logged saying so. In verbose mode, all values for the offending item are logged.
In practice, this change only affects the
[config]section; all other cassandane.ini parameters are read individually, and will continue doing whatever they already did.