Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC compile options in Makefile.am #65

Closed
surfermarty opened this issue Oct 18, 2016 · 3 comments
Closed

GCC compile options in Makefile.am #65

surfermarty opened this issue Oct 18, 2016 · 3 comments
Assignees
@elliefm
Labels
2.5 affects 2.5 3.0 affects 3.0

Comments

@surfermarty
Copy link
Contributor

Line 1450 of Makefile.am in the 2.5.10 release has a GCC compile option hardcoded, which breaks compilation on the Solaris Studio compilers. This flag should only be used if GCC is the compiler.
elliefm added a commit that referenced this issue Oct 26, 2016
@elliefm
build: only use -Wno-sign-compare when C compiler supports it
1130f3d 
This is supposed to fix #65 but is untested on Solaris Studio.
@elliefm elliefm reopened this Oct 26, 2016
@elliefm elliefm self-assigned this Oct 26, 2016
@elliefm elliefm added 2.5 affects 2.5 3.0 affects 3.0 labels Oct 26, 2016
@elliefm
Copy link
Contributor

elliefm commented Oct 26, 2016

I think this is fixed (on both 2.5 and master) by the commits referenced above, but I don't have Solaris Studio to verify with. If you're able to verify that it would be helpful.

@surfermarty
Copy link
Contributor Author

Yes - this commit resolves the issue on Solaris with the Studio Compilers - thanks.

@elliefm
Copy link
Contributor

elliefm commented Oct 26, 2016

Cool, thanks for verifying that :)

@elliefm elliefm closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliefm elliefm

Labels
2.5 affects 2.5 3.0 affects 3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliefm @surfermarty