Squatter: Don't crash on assert() in lib/cyrusdb_twoskip.c:fetch()->assert(keylen) #3892

mosvald · 2022-02-02T08:26:13Z

This checks return value from mboxname_from_external() and if it is NULL
or empty string, just inform about the invalid mailbox name instead of
crashing.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1911689

…ssert(keylen) This checks return value from mboxname_from_external() and if it is NULL or empty string, just inform about the invalid mailbox name instead of crashing. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1911689 Signed-off-by: Martin Osvald <mosvald@redhat.com>

brong

Good catch - yes, that's reasonable. Maybe twoskip fetch should just return NOTFOUND rather than aborting on fetch("") - though running mboxtree on that will do EVERYTHING, so this patch is good anyway.

mosvald force-pushed the master branch from 3011e32 to f23115a Compare February 2, 2022 09:18

brong approved these changes Feb 28, 2022

View reviewed changes

brong merged commit 924383a into cyrusimap:master Apr 24, 2023

elliefm added backport-to-3.8 for PRs that are to be backported to 3.8 and removed backport-to-3.8 for PRs that are to be backported to 3.8 labels Apr 25, 2023

elliefm added backport-to-3.6 for PRs that are to be backported to 3.6 and removed backport-to-3.6 for PRs that are to be backported to 3.6 labels May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Squatter: Don't crash on assert() in lib/cyrusdb_twoskip.c:fetch()->assert(keylen) #3892

Squatter: Don't crash on assert() in lib/cyrusdb_twoskip.c:fetch()->assert(keylen) #3892

mosvald commented Feb 2, 2022

brong left a comment

Squatter: Don't crash on assert() in lib/cyrusdb_twoskip.c:fetch()->assert(keylen) #3892

Squatter: Don't crash on assert() in lib/cyrusdb_twoskip.c:fetch()->assert(keylen) #3892

Conversation

mosvald commented Feb 2, 2022

brong left a comment

Choose a reason for hiding this comment