JSON Web Token: support nbf and exp claims
#4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See RFC 7519, Section 4: Specific applications of JWTs will require implementations to understand and process some claims in particular ways. However, in the absence of such requirements, all claims that are not understood by implementations MUST be ignored. Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
ksmurchison
approved these changes
Jun 7, 2023
elliefm
added
backport-to-3.8
|
FYI you need to use the "backport-to..." label if you want me to backport it, I don't look for plain version labels on PRs, those are for describing which versions are affected by a bug. Is this a bug fix or a new feature? It looks like a feature, and 3.8 is stable now and doesn't get new features, only bug fixes. |
|
@elliefm thanks, did not know to use the "backport-to" label. It's a feature, not a bug. So no backport then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the JSON Web Token code to
nbfclaimexpclaimThe initial code was contributed by @bamthomas in #4515. Thanks! This PR adds more strict validation invalid JSON claims and makes the cunit test code more maintainable.