Revert "tls.c: need to free SSL_SESSION when removing it from cache" #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #4785. |
This reverts commit a3523d4. Closes: cyrusimap#4785
dilyanpalauzov
force-pushed
the
no_session_free_in_remove_session_cb
branch
from
0840940
to
6bbe2fe
Compare
elliefm
added
backport-to-3.8
elliefm
approved these changes
Feb 25, 2024
|
@ksmurchison I'm happy with this, but can I get a second opinion? Thanks I have no insight about where the leak really is (I haven't looked though), but there's enough crash reports to suggest that this wasn't the fix for it. |
|
Hmm. Let me think about it. My patch definitely made valgrind happy. Where are the crash reports? |
|
In #4785 |
ksmurchison
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3523d4.
imapd does crash sometimes, when it handles the TLS connection. #4785 describes such reports from different users.
In such cases Cyrus can log “no shared cipher in SSL_accept() -> fail” or “unexpected eof while reading in SSL_accept() -> fail”.
The recommendation at openssl/openssl#23031 (comment) also states, than doing
SSL_SESSION_free()during remove_session_cb() is wrong. If there were leaks, there is probably another case where there is a missing SSL_SESSION_free() call but this place is not right.• backport to 3.10 and 3.8