Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicaonly reset #4867

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Replicaonly reset #4867

merged 2 commits into from
Mar 27, 2024

Conversation

brong
Copy link
Member

@brong brong commented Mar 26, 2024

Fixes two more replicaonly issues seen in production today!

@brong brong requested a review from ksmurchison March 26, 2024 12:10
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes

@brong
Copy link
Member Author

brong commented Mar 26, 2024

LGTM as long as CI passes

Took me longer to write it than for you to review it! And it only took a few minutes to write it

@brong
Copy link
Member Author

brong commented Mar 26, 2024

hah, it's gonna fail - my own tests hit the Fastmail.sync_reset tests; got some IOERROR around conversations. Will check more later.

@ksmurchison ksmurchison self-requested a review March 26, 2024 16:23
@brong brong merged commit d8da38b into master Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants