Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMAP Email: update Email/import logic for receivedAt property #4884

Merged
merged 3 commits into from Apr 15, 2024

Conversation

rsto
Copy link
Member

@rsto rsto commented Apr 11, 2024

This updates Email/import to set the receivedAt property to:

  • the Email/import receivedAt argument, if present
  • the value of the X-Deliveredinternaldate header, if present
  • the value of the first valid Received header
  • the value of the Date header, if present
  • the current time, if none of the above are present or valid

This changes a couple of internals of the test without changing
any of its expected outcomes.
@rsto rsto requested review from ksmurchison and brong April 11, 2024 10:42
imap/jmap_mail.c Outdated Show resolved Hide resolved
imap/jmap_mail.c Outdated Show resolved Hide resolved
@rsto rsto force-pushed the jmap_email_import_receivedat branch 2 times, most recently from 1af9f6c to 537666a Compare April 11, 2024 11:45
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, your original description was better. I just missed "first valid Received" and read it as "first Received". I think what you had is more clear and less redundant than the new description. Sorry.

This updates Email/import to set the receivedAt property to:

- the Email/import receivedAt argument, if present
- the value of the X-Deliveredinternaldate header, if present
- the value of the first valid Received header
- the value of the Date header, if present
- the current time, if none of the above are present or valid
@rsto rsto force-pushed the jmap_email_import_receivedat branch from 537666a to ed5f407 Compare April 11, 2024 11:53
@rsto
Copy link
Member Author

rsto commented Apr 11, 2024

Thanks, updated to old description.

@rsto rsto merged commit 19961c5 into master Apr 15, 2024
2 checks passed
@rsto rsto deleted the jmap_email_import_receivedat branch April 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants