Skip to content

Commit

Permalink
configure.ac: add warning about plugindir mismatch (issue #473)
Browse files Browse the repository at this point in the history
  • Loading branch information
ksmurchison committed Sep 15, 2017
1 parent e1ddba9 commit 2ea0649
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion configure.ac
Expand Up @@ -1673,9 +1673,26 @@ echo "Build Info"
echo " Shared libraries ......: $enable_shared"
echo " Static libraries ......: $enable_shared"
echo " CFLAGS ................: $CFLAGS"
echo " CXXFLAGS ..............: $CXXFLAGS"
echo " LIBS ..................: $LIBS"
echo " LDFLAGS ...............: $LDFLAGS"
echo
if test "$plugindir" != "$prefix/lib/sasl2"; then
echo "********************************************************"
echo "* WARNING:"
echo "* Plugins will be installed into $prefix/lib/sasl2,"
echo "* but the library will look for them in $plugindir."
echo "* You need to make sure that the plugins will eventually"
echo "* be in $plugindir -- the easiest way is to make a"
echo "* symbolic link from $plugindir to $prefix/lib/sasl2,"
echo "* but this may not be appropriate for your site, so"
echo "* 'make install' won't do it for you."
echo "*"
echo "* If you don't want to create a link for some reason,"
echo "* you canset the location where the library will look"
echo "* for plugins by setting the environment variable"
echo "* SASL_PATH to the path the library should use."
echo "********************************************************"
echo
fi
echo "Now type 'make' to build $PACKAGE"
echo

3 comments on commit 2ea0649

@flowerysong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the utility is to having a hard-coded default install location that doesn't respect the setting from --with-plugindir; it would seem better to me to change

sasldir = $(prefix)/lib/sasl2
to set sasldir to the same value as plugindir. People who need the current behaviour would be able to override sasldir with e.g. make sasldir=/usr/lib/sasl2 (an approach we currently use to make sure they're installed to plugindir) but it would be more difficult for people to end up with a broken install.

@JanParcel
Copy link
Contributor

@JanParcel JanParcel commented on 2ea0649 Sep 15, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanParcel
Copy link
Contributor

@JanParcel JanParcel commented on 2ea0649 Sep 15, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.