Fix #587

Off by one error in common.c, CVE-2019-19906. Thanks to Stephan Zeisberg for reporting
cyrusimap · Feb 18, 2020 · 332b8c5 · 332b8c5
1 parent a7b92c8
commit 332b8c5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/common.c b/lib/common.c
@@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t *alloclen,
 
   if (add==NULL) add = "(null)";
 
-  addlen=strlen(add); /* only compute once */
+  addlen=strlen(add)+1; /* only compute once */
   if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
     return SASL_NOMEM;