Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic test infrastructure #598

Merged
merged 1 commit into from Mar 19, 2020
Merged

Conversation

simo5
Copy link
Contributor

@simo5 simo5 commented Mar 18, 2020

This runs in make check so hopefully it will work as CI via travis

First test is for SASL/GSSAPI

Fixes #595

@simo5 simo5 force-pushed the gssapi_tests branch 4 times, most recently from ec46d3f to 3d429c6 Compare March 19, 2020 15:39
@simo5
Copy link
Contributor Author

simo5 commented Mar 19, 2020

@quanah can you take a look at this ?

@iboukris
Copy link
Contributor

Cool!

First test is for SASL/GSSAPI

Signed-off-by: Simo Sorce <simo@redhat.com>

:x
@quanah
Copy link
Contributor

quanah commented Mar 19, 2020

@simo5 Yes, will look in more detail shortly. :)

@simo5
Copy link
Contributor Author

simo5 commented Mar 19, 2020

@quanah if this works, we can ask #586 to add a test to validate it works, and I can start adding more tests for other parts of SASL as well

@aiobofh
Copy link
Contributor

aiobofh commented Mar 19, 2020

@simo5 awsome work! I'll try to find some time somewhere to write some tests on credential delegation and maybe loading of specified store. Can't give a deadline - Work is taking a bit more time now when the world is what it is. But hopefully soon...

@quanah quanah merged commit 18ff41d into cyrusimap:master Mar 19, 2020
@quanah
Copy link
Contributor

quanah commented Mar 19, 2020

@simo5 For the 2.1 release branch, is this OK to add as-is, or do we need to tweak it?

@simo5
Copy link
Contributor Author

simo5 commented Mar 20, 2020

@quanah With the caveat that tests are not run on macosx (because I do not have one and travis is too slow to do iterative experiments) I do not see a problem having them in the release.
It does add a dependency in the make check step though.
If that is a problem we can add a make tests target instead so that ppl that do not want to have that dependency in the way can avoid it.

@simo5
Copy link
Contributor Author

simo5 commented Mar 20, 2020

@quanah aaand I just realized some files have this as the header:
/* TBD, add (C) */
I can follow up with a PR that fixes that, what License is acceptable? Should I add CMUs one ?

@quanah
Copy link
Contributor

quanah commented Apr 8, 2020

@simo5 I would ask on the cyrus devel list for the license question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test infrastucture and github CI workflow?
4 participants