Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MAX_REQ_LEN to allow transport of more sophisticated credent… #611

Closed

Commits on May 10, 2021

  1. Increase MAX_REQ_LEN to allow transport of more sophisticated credent…

    …ials
    
    The constant MAX_REQ_LEN, which controls the maximum size of a password
    accepted by saslauthd, is increased from 256 to 65536.  Though a simple
    human-typed plaintext password is unlikely to ever be so big, this
    allows saslauthd to accept other, larger credentials.  In particular,
    this is large enough to allow saslauthd to receive SAML2 security
    assertions and pass them through to a PAM authenticator for verification.
    
    MAX_REQ_LEN also affects the fixed-size buffers allocated for "login",
    "service", "realm", and "client_addr", though only "password" needs
    to be enlarged for this use-case.  However, at this point it doesn't
    seem to be worth the effort/complexity to introduce a separate constant
    to independently control the size of the "password" buffer.
    
    Signed-off-by: Matt Marjanović <maddog@mir.com>
    mdoggydog committed May 10, 2021
    Copy the full SHA
    89d0527 View commit details
    Browse the repository at this point in the history