Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Define the missing crypto_compat_version version. #623

Merged
merged 1 commit into from Sep 28, 2021

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Sep 9, 2020

This fixes the build with slibtool (https://git.foss21.org/slibtool) which is an alternative implementation for GNU libtool.

rdlibtool  --tag=CC   --mode=link clang  -Wall -W -g -O2 -version-info  -no-undefined  -o libcrypto_compat.la  crypto-compat.lo  -lresolv 
rdlibtool: error: option [--version-info] requires a value 
make[2]: *** [Makefile:481: libcrypto_compat.la] Error 2
make[2]: Leaving directory '/tmp/cyrus-sasl/common'
make[1]: *** [Makefile:677: all-recursive] Error 1
make[1]: Leaving directory '/tmp/cyrus-sasl'
make: *** [Makefile:545: all] Error 2

The GNU libtool documentation for -version-info says:

This flag accepts an argument of the form ‘current[:revision[:age]]’. So, passing -version-info 3:12:1 sets current to 3, revision to 12, and age to 1.

If either revision or age are omitted, they default to 0. Also note that age must be less than or equal to the current interface number.

https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

Both the syntax of current[:revision[:age]] and only defining anything for when revision or age is missing indicates that at least current is required. However GNU libtool is happy to silently ignore this error while slibtool prints an error.

rdlibtool: error: option [--version-info] requires a value 

If another version value other than 0:0:0 is desired I can change that.

@orbea
Copy link
Contributor Author

orbea commented Mar 22, 2021

Please see this downstream issue: https://bugs.gentoo.org/775875

The fix is already applied in gentoo.

@quanah
Copy link
Contributor

quanah commented May 5, 2021

Please update your commit(s) to be signed off on in accordance with our DCO. Thanks!

Signed-off-by: orbea <orbea@riseup.net>
@orbea
Copy link
Contributor Author

orbea commented May 6, 2021

Please update your commit(s) to be signed off on in accordance with our DCO.

Should be done.

@quanah quanah added this to the 2.1.28 milestone Sep 28, 2021
@quanah quanah merged commit 51aa4f0 into cyrusimap:master Sep 28, 2021
@orbea orbea deleted the version-info branch September 28, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants