In the ChatRoomService example, BroadcastAllAsync (x => x.OnJoin) x always NullReferenceException

[yoohoxiao]

How to solve this problem?

[neuecc]

it is caused from does not call RegisterStreamingMethod before call at once.
requires OnJoin before Broadcast...
However, null is not desirable, so I'd like to fix it.
thanks.

[yoohoxiao]

So how do I fix this problem now?

[neuecc]

Who calls BroadcastAll?
In the chat scenario, although I think that someone will surely start after Join.

[yoohoxiao]

public async Task<ServerStreamingResult<ChatRoomMember>> OnJoin()
{
  return await GetStreamingContextRepository().RegisterStreamingMethod(this, OnJoin);
}

[yoohoxiao]

Now this problem can not be resolved, there are other ways, I do not know where to modify.

[neuecc]

please show reproduce client code.
below code is works fine.

static async Task RunChat(ChannelContext ctx)
{
    // create room
    var client = ctx.CreateClient<IChatRoomService>();

    var room = await await client.CreateNewRoom("test", "A"); // TODO:IChatRoomCommand sample is old so require await await...

    var result = await await client.SendMessage(room.Id, "foo bar baz");
    Console.WriteLine("Send success:" + result);
}

[yoohoxiao]

public IEnumerator Join(string roomId, string nickName)
{
       var r = client.Join(roomId, nickName).ResponseAsync.ToYieldInstruction();
       yield return r;
}

[yoohoxiao]

Do you need to do two "ToYieldInstruction" here?

[neuecc]

ah, sorry, require subscribe OnJoin before do anything.

[neuecc]

I've fixed sample code and upload v0.5.1.1 includes this fix.
4d1c8af

main fix is add new api, when creating StreamingContextRepository

new StreamingContextRepository<IChatRoomStreaming>(connection, this);

[yoohoxiao]

Sorry, did not see the version update!

[yoohoxiao]

public async UnaryResult<RoomResponse> CreateNewRoom(string roomName, string nickName)
Are you sure you can write this way?
Why the editor that need to add Task , or can not use async.

[neuecc]

this is for C# 7.0 only, if you have to use old c#, change signature to Task<UnaryResult<T>>.
(but for Unity, generates IObservable<T> code).

[yoohoxiao]

public interface IChatRoomCommand
{
           IObservable<UnaryResult<global::ShareType.RoomResponse>> CreateNewRoom(string roomName, string nickName);
}

Does Unity3d need this?

[neuecc]

moc.exe automatically convert and generate interface.
like this https://github.com/neuecc/MagicOnion/blob/master/src/MagicOnion.Client.Unity/Assets/Scripts/MagicOnionGenerated.cs#L369-L381