prevent tp_new() optimisation from breaking external types with known…

… typeobj
cython · Mar 29, 2013 · 3257193 · 3257193
1 parent dd29ccb
commit 3257193
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Cython/Compiler/Optimize.py b/Cython/Compiler/Optimize.py
@@ -2189,7 +2189,9 @@ def _handle_any_slot__new__(self, node, function, args,
 
         if type_arg.type_entry:
             ext_type = type_arg.type_entry.type
-            if ext_type.is_extension_type and ext_type.typeobj_cname:
+            if (ext_type.is_extension_type and ext_type.typeobj_cname and
+                    ext_type.scope.global_scope() == self.current_env().global_scope()):
+                # known type in current module
                 tp_slot = TypeSlots.ConstructorSlot("tp_new", '__new__')
                 slot_func_cname = TypeSlots.get_slot_function(ext_type.scope, tp_slot)
                 if slot_func_cname:

diff --git a/tests/run/tp_new_cimport.srctree b/tests/run/tp_new_cimport.srctree
@@ -42,7 +42,7 @@ def test_sub():
 
 ######## a.pxd ########
 
-cdef class ExtTypeA:
+cdef api class ExtTypeA[type ExtTypeA_Type, object ExtTypeAObject]:
     cdef readonly attrA
 
 ######## a.pyx ########