Skip to content

Commit

Permalink
Remove allowed_failure from Python 3.12 (#5815)
Browse files Browse the repository at this point in the history
and disable profiling tests there, since it doesn't look like
we'll be able to fix them.

Knowing about other regressions is probably more important than
testing profiling...
  • Loading branch information
da-woods committed Nov 14, 2023
1 parent 7683cb1 commit f71205d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ jobs:
env: [{}]

include:
# Temporary - Allow failure on Python 3.12+ jobs (https://github.com/cython/cython/issues/5470)
- python-version: "3.12"
allowed_failure: true
- python-version: "3.13-dev"
allowed_failure: true

Expand Down
3 changes: 2 additions & 1 deletion runtests.py
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,6 @@ def get_openmp_compiler_flags(language):
'tag:cppexecpolicies': require_gcc("9.1"),
}


# TODO: use tags
VER_DEP_MODULES = {
# tests are excluded if 'CurrentPythonVersion OP VersionTuple', i.e.
Expand Down Expand Up @@ -521,6 +520,8 @@ def get_openmp_compiler_flags(language):
]),
# See https://github.com/python/cpython/issues/104614 - fixed in Py3.12.0b2, remove eventually.
(3,12,0,'beta',1): (operator.eq, lambda x: 'cdef_multiple_inheritance' in x or 'pep442' in x),
# Profiling is broken on Python 3.12
(3,12): ((lambda actual, v3_12: actual[:2]==v3_12), (lambda x: x.find("pstats") != -1)),

}

Expand Down

0 comments on commit f71205d

Please sign in to comment.