Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cythonize 0.29.x: use force=None as default instead of force=False #5712

Merged
merged 1 commit into from Sep 21, 2023

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Sep 19, 2023

I completely overlooked this in #5307,
that backport was useless because the signature of cythonize is

def cythonize(..., force=False, ...)

in 0.29.x instead of

def cytonize(..., force=None, ...)

like it is on 3.x, meaning that setting CYTHON_FORCE_REGEN=1 had no effect.

@haampie
Copy link
Contributor Author

haampie commented Sep 21, 2023

@scoder does cython still do 0.29 releases? If so, this would be helpful to have

@scoder scoder added this to the 0.29.37 milestone Sep 21, 2023
@scoder
Copy link
Contributor

scoder commented Sep 21, 2023

Right, that should work "better". :)
Thanks.

@scoder scoder merged commit 2535803 into cython:0.29.x Sep 21, 2023
74 of 94 checks passed
@haampie haampie deleted the fix/backport-CYTHON_FORCE_REGEN branch September 22, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants