Backport CYTHON_FORCE_REGEN=1 feature to 0.29 #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HON_FORCE_REGEN=1, e.g. from external build systems.
haampie
changed the title
|
@scoder is it possible to backport this? I know it's not a Cython bugfix, but being able to reliably re-cythonize older release tarballs with broken generated sources would be very helpful. Is CI failing as a result of this PR? |
No. The failures are known failures for the 0.29.x branch |
|
Thanks. Seems reasonable. And helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of #5089, it seems like
the general opinion is that it's not a good idea to ship generated sources in
Python package release tarballs.
Right now there are tons of Python package releases that do include generated
C sources, and they may be generated from Cython versions that were not forward
compatible or had bugs. It would make sense to re-cythonize those packages with
the same minor version of cython (typically 0.29.x), without having to patch
force=Trueinto each and every setup.py script, especially sincesetup.py cleanis not generally defined as a command. Notice that in some cases certain packages
simply won't update their tarballs and release bugfix releases, so it would be good
to have this option.
Therefore, backport
CYTHON_FORCE_REGENfrom 3.x -> 0.29.x.