New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old build_ext with new cythonize(...) version. #1456
Conversation
The old build_ext is now named old_build_ext, replaced with the one from Cython/Build.
We'll need an extended test cycle for the 0.25 release anyway, so let's get this in and fix it in master. |
This breaks https://github.com/zeromq/pyzmq |
In order for this to be a viable replacement to |
I agree that this is not a replacement for calling a customized |
And I'd want to think long and hard about what command line options to add, given that they're even harder to change. |
And it serves as nice "documentation" on how to customize the |
breaks pyyaml. See #1498 |
A new build_ext command was added in Cython 0.25 but it breaks Astropy. cython/cython#1456 Cython 0.25.1 was released to revert this change: cython/cython@4ecdd3e This commit ensures that we always use the old build_ext, whatever the Cython version is.
A new build_ext command was added in Cython 0.25 but it breaks Astropy. cython/cython#1456 Cython 0.25.1 was released to revert this change: cython/cython@4ecdd3e This commit ensures that we always use the old build_ext, whatever the Cython version is.
Rather than redirect everyone to the one in Cython.Build, simply upgrade the Cython.Distutils version. In particular, this is the version picked up by setuptools.
Notably, however, the new one takes far fewer options (this configuration primarily moved into in-file directives). The old one is kept as Cython.Distutils.old_build_ext to ease migration; we should consider which, if any, additional options should be moved to the new one.