Fix types of values in libc.limits #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdemeyer
force-pushed
the
libc_limits
branch
from
e325b8b
to
5c940d1
Compare
jdemeyer
force-pushed
the
libc_limits
branch
from
5c940d1
to
d75fabd
Compare
jdemeyer
force-pushed
the
libc_limits
branch
from
d75fabd
to
e912667
Compare
scoder
reviewed
Nov 24, 2017
| entry.is_const or | ||
| entry.is_cfunction or | ||
| entry.is_builtin or | ||
| entry.type.is_const): |
There was a problem hiding this comment.
Would be nice to also have a test case for this change.
There was a problem hiding this comment.
There is an existing test case in tests/run/carrays.pyx. In fact, I made this change because that test case broke.
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently gives
-1on a 64-bit system because Cython thinks thatLONG_MAXis of typeint.This requires #2020.