Extended the examples of string.rst and put them in the examples directory for testing. #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory for testing.
scoder
reviewed
Jun 17, 2018
| # A type cast to `object` or `bytes` will do the same thing: | ||
| py_string = <bytes> c_string | ||
|
|
||
| free(c_string) |
There was a problem hiding this comment.
This definitely needs a try-finally, because the object creation might fail with MemoryError.
And since that adds even more complexity to an originally very simple piece of example code, I'd rather leave this specific 2-line snippet untouched.
| # get pointer and length from a C function | ||
| get_a_c_string(&c_string, &length) | ||
|
|
||
| py_bytes_string = c_string[:length] |
gabrieldemarmiesse
force-pushed
the
test_string
branch
from
6f3a711
to
c6be828
Compare
scoder
reviewed
Jun 17, 2018
| try: | ||
| py_bytes_string = c_string[:length] # Performs a copy of the data | ||
| finally: | ||
| PyMem_Free(c_string) |
There was a problem hiding this comment.
Ah, no, please use plain malloc() and free() here. The intention is to show how to interact with something C-ish (e.g. an external C library), not with something that understands the CPython C-API.
There was a problem hiding this comment.
My bad, I though it would be a good example. I'll change it.
…ippet back to the .rst file.
gabrieldemarmiesse
force-pushed
the
test_string
branch
from
c6be828
to
5656dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added examples of manipulation of strings in Cython (the
c_func.pyxandc_func.pxd) because I think it's a good thing to show more cython examples (even if they are trivial).If you don't want them in the docs, we can keep them in the examples directory (for the tests) and not display them in the documentation.