New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythonise the docs #4187: "Extension types (aka. cdef classes)" (cdef_classes.rst) #4232
Conversation
This comment has been minimized.
This comment has been minimized.
I think a note is best. Once readers have seen it on one page, it's easy to ignore on others. Highlighting the paragraph in a Note makes it clear that it's not part of the main page content. |
@scoder @da-woods @Bluenix2 @mattip Faced, as I understand it, a kind of this (#1428) issue. Described the behavior here. (Not sure if there is enough difference to create a new issue) The problem is that if people follow this tutorial step by step, they will face this behavior. If we want to show people pure Python code using It seems that this rather unpleasant problem can be solved quite simply, as far as I understand, there is already progress on its solution: #4063 Sorry for sending notifications, I just think if you can, it would be good to try to think about a solution / review the proposed PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to show people pure Python code using
pxd
, they should definitely be warned about this issue.
"Creating the .pxd file may not cause Cython to re-compile the .py file. If you are using setup.py
to build you can force recompilation with the --force
argument."?
It seems that this rather unpleasant problem can be solved quite simply, as far as I understand, there is already progress on its solution: #4063
I think the solution is pretty close to complete - it just needs the testing tidied up a bit. It's probably worth trying to get it merged fairly soon.
It seems that the author of that PR is not in the business of improving tests. Oh yes, you, as a cython collaborator, can make commits in PR. Is there anything I can do to help improve those tests? |
Yes, it looks like a temporary solution, but it is still unpleasant to compile, for example, a large number of files every time you change one. |
Co-authored-by: scoder <stefan_ml@behnel.de>
Co-authored-by: scoder <stefan_ml@behnel.de>
@scoder Maybe we will merge this PR? |
oops experimented a little with fork branches |
@scoder please merge this PR. |
Thanks |
Thanks you, finally this is merged .. |
Continuing to Pythonize Сython documentation!
This PR Pythonizes this documentation page.
Lots of process details and standardization are found here: #4187
BTW, the fact that this is a draft PR does not mean that you can no longer leave review, as I understand it, so I urge you to do it.