Optimize dispatch for fused memoryview types #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By converting them to a memoryview once, checking some of the details of that, and then using that to initialize the Cython memoryview. Also closes cython#3798 as an implementation detail. I measure something like ~7% speedup on a small toy example that selects between 3 types of memoryviews
|
Draft because it's broken PyPy2 |
da-woods
commented
Oct 9, 2022
I wasn't able to diagnose what's going on, but it doesn't work if you go via an intermediate Python memoryview
Doesn't need special utility code
mattip
reviewed
Oct 10, 2022
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting them to a memoryview once, checking some of the
details of that, and then using that to initialize the
Cython memoryview.
Also closes #3798 as an implementation detail.
I measure something like ~7% speedup on a small toy example
that selects between 3 types of memoryviews