fix changed code

[mattip]

PR #5556 changed the code to use __Pyx_PySequence_ITEM, but changed a bit too much on this line. This was causing PyPy to fail the fused_def test, after the fix the test passes.

This is the change in the context of the PR

[da-woods]

Thanks. I wonder why we didn't see it in PyPy in the CI? I'd thought we didn't allow failures on PyPy...

[mattip]

Dunno. I think this is the one. It seems to pass here, but failed on my weekly PyPy + Cython build

[da-woods]

The only thing you're obviously doing differently is -DCYTHON_USE_TYPE_SPECS, although (based on a quick look) I don't see why that would affect this code.

Do you think we should be setting -DCYTHON_USE_TYPE_SPECS by default for PyPy?

[mattip]

It seems that is redefined to 0 anyway, so that flag is superfluous in CI:

cython/Cython/Utility/ModuleSetupCode.c

Lines 126 to 127 in f082052

	#undef CYTHON_USE_TYPE_SPECS
	#define CYTHON_USE_TYPE_SPECS 0

[mattip]

The PyPy CI run is skipping the "Setup python" step since the condition is wrong

cython/.github/workflows/ci.yml

Line 223 in f082052

if: startsWith(matrix.python-version, '3.')

[mattip]

While we are at it, I am not sure what the cache step in CI is for. Is something else skipped if the cache is found? It is emitting warnings. A newer workflow is https://github.com/actions/cache/tree/main, but I am not sure how the caching is meant to work and how to check that a cache is being used.

[da-woods]

While we are at it, I am not sure what the cache step in CI is for. Is something else skipped if the cache is found? It is emitting warnings. A newer workflow is https://github.com/actions/cache/tree/main, but I am not sure how the caching is meant to work and how to check that a cache is being used.

ccache skips compilation of a file if the file is identical to one it's seen before (and all the defines/command line flags are the same). From the point of view of the tests it should be the same - it just accelerates the C compilation step by using a result from earlier

[da-woods]

The PyPy CI run is skipping the "Setup python" step since the condition is wrong

cython/.github/workflows/ci.yml

Line 223 in f082052

if: startsWith(matrix.python-version, '3.')

That's likely it. So possibly we're not actually setting up PyPy and just running everything in CPython... I'll investigate and fix if needed (but likely tomorrow).

Thanks for spotting that!

[mattip]

I submitted #5582