Fix invalid fastcall dict when keywords are passed #5675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cython#5665 I'm slightly surprised this hasn't caused more bugs. We're passing a dict where we should be passing a tuple of names. Replacement should hopefully be right, but I don't know how optimized or otherwise it is.
da-woods
force-pushed
the
invalid-fastcall-dict
branch
from
294de86
to
81cc077
Compare
|
Thank you! I can confirm that with this patch applied, I can get gssapi to work. |
|
We could probably handle the kwargs case better, but this prevents crashes, so we don't lose anything. |
|
Thanks, also for the testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5665
I'm slightly surprised this hasn't caused more bugs. We're passing a dict where we should be passing a tuple of names.
Replacement should hopefully be right, but I don't know how optimized or otherwise it is.