Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using strings for exception_value of func_type #5710

Merged
merged 14 commits into from
Mar 7, 2024
Merged

Avoid using strings for exception_value of func_type #5710

merged 14 commits into from
Mar 7, 2024

Commits on Sep 17, 2023

  1. Avoid using strings for exception_value of func_type 

    The main advantage is that we don't end up hugely sensitive to
the exact string representation of a particular number.

Fixes cython#5709
    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    4c0d095 View commit details
    Browse the repository at this point in the history

  2. Fix Cython self-build hopefully

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    3f29ce4 View commit details
    Browse the repository at this point in the history

  3. Shift the exception_value logic into ExprNode

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f3f3dd1 View commit details
    Browse the repository at this point in the history

  4. Fix codegen when exception_value == 0

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    dab7347 View commit details
    Browse the repository at this point in the history

  5. Remove debugging code

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    b9fe05c View commit details
    Browse the repository at this point in the history

  6. Fixup remaining tests (hopefully)

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    63dc932 View commit details
    Browse the repository at this point in the history

  7. Fix BoolNode compile-time value

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    9417b32 View commit details
    Browse the repository at this point in the history

  8. Avoid boolnode

    @da-woods
    da-woods committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    9666e11 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'master' into avoid-strs-for-functype-exception-value

    @da-woods
    da-woods committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    30325f0 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Comments from review

    @da-woods
    da-woods committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2562ad2 View commit details
    Browse the repository at this point in the history

  2. Assume constant result is already calculated

    @da-woods
    da-woods committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    0ffd487 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: scoder <stefan_ml@behnel.de>
    @da-woods @scoder
    da-woods and scoder committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    1abb981 View commit details
    Browse the repository at this point in the history

  4. More review stuff

    @da-woods
    da-woods committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9dd95fa View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'master' into avoid-strs-for-functype-exception-value

    @da-woods
    da-woods committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e49988c View commit details
    Browse the repository at this point in the history