Fix C++17 error: standard attributes in middle of decl-specifiers (CYTHON_UNUSED) #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…THON_UNUSED) This is only relevant on Python 3.13+ Fixes cython#5790
|
I belive there should be a test for this, so it won't regress. However, I don't currently have the capacity to add it. |
We could probably make sure that it gets triggered by one of the C++ tests. But it's a bugfix either way. Let's merge it. |
|
Thanks |
gnossen
pushed a commit
to grpc/grpc
that referenced
this pull request
Nov 2, 2023
Since Python 3.7, it’s called by [`Py_Initialize`](https://docs.python.org/3/c-api/init.html#c.Py_Initialize) and doesn’t need to be called manually, so this removal has no effect. Since Python 3.9, it does nothing, and in [Python 3.13](https://docs.python.org/3.13/whatsnew/3.13.html), it [will be removed](python/cpython#105182), which makes this change necessary. References: https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads python/cpython#105182 ---- Together with the changes discussed in #33918 and with a [Cython fix](cython/cython#5791) to be released in 3.0.5, this allowed us to build and test our `grpc` package with Python 3.13.0a1 and Cython 3.0.4. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
rinarakaki
pushed a commit
to rinarakaki/cython
that referenced
this pull request
Nov 3, 2023
…THON_UNUSED) (cythonGH-5791) This is only relevant on Python 3.13+ Fixes cython#5790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only relevant on Python 3.13+
Fixes #5790
Still testing this.