Support weakref in limited api cdef classes #5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cython#5793. Note that this won't work on Python versions <3.9. (The code will compile fine, but the classes won't be weak referenceable).
|
Note that this won't work on Python versions <3.9. (The code will compile fine, but the classes won't be weak referenceable).
We could print a C compiler warning when we detect that case. That would make the problem visible. It's then best for users to either require a newer Python version or work around the missing feature at runtime. We shouldn't fail the compilation for this.
|
|
This is next on my list of limited API stuff that I'm threatening to merge fairly soon unless there are objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5793.
Note that this won't work on Python versions <3.9. (The code will compile fine, but the classes won't be weak referenceable).