Modified "pretend_to_initialize" for c++ #5920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case we actually have to initialize rather than just do nothing. Fixes cython#5278. Supercedes cython#5296 (I think this is better since it limits the amount of work Cython itself has to do)
|
This seems better suited for a utility code file section than sequential code generation.
|
da-woods
commented
Feb 10, 2024
da-woods
added a commit
to da-woods/cython
that referenced
this pull request
Mar 31, 2024
In this case we actually have to initialize rather than just do nothing. Fixes cython#5278. * Move code to utility code file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case we actually have to initialize rather than just do nothing. Fixes #5278.
Supercedes #5296 (I think this is better since it limits the amount of work Cython itself has to do)