Warn about discarting const qualifier #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusvalo
force-pushed
the
warn_const_discart
branch
from
0e0fd21
to
60a9911
Compare
|
I'd personally assign the rhs/lhs types to local variables at the beginning of the check function, but that's a style detail. I'm fine with this change, too.
|
I have no problem even with fixing the style. I applied the suggestion and merged master. If the CI is green and there won't be any comment, I will merge the PR. |
matusvalo
added a commit
to matusvalo/cython
that referenced
this pull request
Feb 11, 2024
da-woods
pushed a commit
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5639