Limited API fixes based on compile tests #6136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * Fused function binding * C array conversion * Dataclass fallback code * Getting char* from unicode (on some versions - on others it's just a runtime exception).
|
I haven't enabled any specific tests on this because it was tested alongside other pending limited API changes, so I don't know how much this fixes on its own. |
da-woods
commented
Apr 7, 2024
| @@ -241,6 +241,31 @@ static CYTHON_INLINE const char* __Pyx_PyObject_AsString(PyObject* o) { | |||
| #if __PYX_DEFAULT_STRING_ENCODING_IS_ASCII || __PYX_DEFAULT_STRING_ENCODING_IS_DEFAULT | |||
| static CYTHON_INLINE const char* __Pyx_PyUnicode_AsStringAndSize(PyObject* o, Py_ssize_t *length) { | |||
| if (unlikely(__Pyx_PyUnicode_READY(o) == -1)) return NULL; | |||
| #if CYTHON_COMPILING_IN_LIMITED_API && __PYX_LIMITED_VERSION_HEX < 0x030A0000 | |||
| PyErr_SetString( | |||
There was a problem hiding this comment.
As far as I can tell, __Pyx_PyUnicode_AsStringAndSize is only ever used in __Pyx_PyObject_AsStringAndSize so it's always used on something that might be a unicode object but isn't known to be. Therefore a runtime error seems appropriate. If it was definitely used on a unicode object I'd probably prefer a compile-time error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: