Freethreading to nogil #6210
Freethreading to nogil #6210
Conversation
For naming consistency
| def put_acquire_freethreading_lock(self): | ||
| def put_acquire_nogil_lock(self): |
There was a problem hiding this comment.
Hmm, seeing this now makes it very ambiguous with Cython's nogil features. That's even worse because it really gives the wrong context. We use "nogil" in Cython's sources all over the place.
A name like "…cpython_nogil…" doesn't seem clear either. Maybe "freethreading" in one word isn't bad after all? _CPYTHON_NOGIL for the target macro and *_freethreading_* in our code base?
There was a problem hiding this comment.
Yes, I agree (now you point that out).
I wonder if we should use "freethreading" everywhere (since it's what Python has chosen to call the build). But I'd also be happy to leave the target macro unchanged.
There was a problem hiding this comment.
Ok. Let's change it everywhere, also in the target macro name. We're freshly introducing it for 3.1, so let's use something really unambiguous.
There was a problem hiding this comment.
OK - that's at #6213
For naming consistency.
#6199 (comment)