New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't change selected features (vuex store) if no diff #57

Merged

geektortoise merged 1 commit into master from lr-OP-586-infinite-loop-viewer-fix

Jul 7, 2021

loic911 commented Jul 1, 2021

No description provided.


          don't change selected features (vuex store) if no diff

d4e46e4

loic911 requested a review from geektortoise

July 1, 2021 09:42

Member

geektortoise commented Jul 7, 2021

Short history about this issue :
Problem :
An infinite loop calling the setter of the selectedFeatures in SelectInteraction.vue https://github.com/cytomine/Cytomine-Web-UI/blob/master/src/components/viewer/interactions/SelectInteraction.vue#L50
Origin : The update of the VueLayers library from 0.11.4 to a recent version has some modifications, especially in our case the deletion of the changeFeature event management ghettovoice/vuelayers@1655c35#diff-be86998557e0eeaeecd7e83d440b9ce1701daf1dd409f9831aacbc153e540e9aL136
With this new version, the changed method associated with the features (https://github.com/cytomine/Cytomine-Web-UI/blob/master/src/components/viewer/interactions/SelectInteraction.vue#L138) trigger a different chain of event and an infinite loop.

I cannot find more information about the specific chaining. However, this modification seems to fix the problem.

geektortoise merged commit 560ca96 into master

geektortoise mentioned this pull request

VueLayers dependency #58

Open

loic911 deleted the lr-OP-586-infinite-loop-viewer-fix branch

July 14, 2021 09:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment