Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Parsl app concurrency with futures #194

Merged
merged 10 commits into from
Apr 29, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Apr 23, 2024

Description

This PR addresses an issue with Parsl app evaluation to enable concurrency throughout _to_parquet() and related. It stems from investigation through #192, originally inspired by work towards documenting #176 (after finding no significant differences in Parsl configurations performance). After making these changes mypy was upset about a few type hints, so I updated these as well to ensure pre-commit checks could pass.

Generally, this work focused on following the patterns mentioned under Parsl documentation on using Futures.

Closes #192

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review April 23, 2024 22:46
cytotable/convert.py Outdated Show resolved Hide resolved
Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I've started looking at the parsl stuff in this repo, so apologies if some of these questions don't make sense.

cytotable/convert.py Show resolved Hide resolved
cytotable/utils.py Outdated Show resolved Hide resolved
@d33bs d33bs requested a review from kenibrewer April 25, 2024 17:30
Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the explanations!

@d33bs
Copy link
Member Author

d33bs commented Apr 29, 2024

Thank you @kenibrewer ! Merging this in.

@d33bs d33bs merged commit 17a4037 into cytomining:main Apr 29, 2024
11 checks passed
@d33bs d33bs deleted the parsl-concurrency branch April 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify concurrency and make relevant changes to improve multithreaded or multiprocessing capabilities
2 participants