Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Dockerfile Pycytominer branch from master to main #1

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 4, 2023

Pycytominer now uses main instead of master as the default branch. This updates the Dockerfile here to be in alignment.

Thanks in advance for any thoughts and suggestions you may have here! Please don't hesitate to let me know if you have any questions.

pycytominer now uses main instead of master as the default branch
@d33bs d33bs marked this pull request as ready for review November 8, 2023 23:04
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we have to bump pycytominer version?

@d33bs
Copy link
Member Author

d33bs commented Nov 9, 2023

Thanks @gwaybio ! The Dockerfile will grab the latest updates from source under the main branch currently. I deferred to keep the functionality here the same for now in case it makes a difference with concerns to CellProfiler usecases. When the time is right, a new image could be pushed to Docker Hub with the 1.0.x tag for general availability. We might want to make sure anything which references the "latest" tag is ready to receive the updates from Pycytominer 1.0.x.

Asides:

  • I wonder if it'd be beneficial to add a "release-based" Dockerfile and/or image here or in the Pycytominer repo (adding to the existing deployments on PyPI and Conda-forge).
  • We may also want to incorporate the cell-locations extra here at some point.

@bethac07 bethac07 merged commit c085ac9 into cytomining:main Nov 13, 2023
@bethac07
Copy link
Member

I wonder if it'd be beneficial to add a "release-based" Dockerfile and/or image here or in the Pycytominer repo (adding to the existing deployments on PyPI and Conda-forge).
We may also want to incorporate the cell-locations extra here at some point.

All of that is fine with me! We can also do commit based tags, since the version just passed through is git checkout $version . This was definitely not the MOST one could do, it was just a minimal version so we could do this. But I am all for more functionality and more efficient/lazier builds.

@d33bs d33bs deleted the update-default-branch branch November 13, 2023 15:21
@d33bs
Copy link
Member Author

d33bs commented Nov 13, 2023

Thanks @bethac07 ! I'll create a pair of issues to track this here and in the Pycytominer repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants