README: Change recommendation for file-nullbyte to only search text files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles This updates the recommended / suggested configuration file presented in the `README.md` file, so that `file-nullbyte` is only searching text files by default (`FILE_NULLBYTE_TEXT=0). Searching binary files for null bytes (`NUL`) makes not too much sense, since it will regularly find such files, and it is perfectly fine for them to contain these bytes. This addresses one aspect of an issue with searching binary files with this particular file check (documented in cytopia#14).
kbabioch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the recommended / suggested configuration file presented in
the
README.mdfile, so thatfile-nullbyteis only searching textfiles by default (
FILE_NULLBYTE_TEXT=0).Searching binary files for null bytes (
NUL) makes not too much sense,since it will regularly find such files, and it is perfectly fine for
them to contain these bytes.
This addresses one aspect of an issue with searching binary files with
this particular file check (documented in #14).